diff --git a/packages/api/src/services/create_page_save_request.ts b/packages/api/src/services/create_page_save_request.ts index 403ccf3f0..084f7da3f 100644 --- a/packages/api/src/services/create_page_save_request.ts +++ b/packages/api/src/services/create_page_save_request.ts @@ -104,7 +104,7 @@ export const createPageSaveRequest = async ({ // create processing item const libraryItem = await createOrUpdateLibraryItem( { - id: articleSavingRequestId, + id: articleSavingRequestId || undefined, user: { id: userId }, readableContent: SAVING_CONTENT, itemType: PageType.Unknown, diff --git a/packages/api/src/services/save_page.ts b/packages/api/src/services/save_page.ts index 6fc21b54f..fafc20dc7 100644 --- a/packages/api/src/services/save_page.ts +++ b/packages/api/src/services/save_page.ts @@ -76,7 +76,7 @@ export const savePage = async ( await createPageSaveRequest({ user, url: input.url, - articleSavingRequestId: clientRequestId, + articleSavingRequestId: clientRequestId || undefined, state: input.state || undefined, labels: input.labels || undefined, folder: input.folder || undefined, diff --git a/packages/api/test/resolvers/article.test.ts b/packages/api/test/resolvers/article.test.ts index d35ef6f4f..a3fd7e034 100644 --- a/packages/api/test/resolvers/article.test.ts +++ b/packages/api/test/resolvers/article.test.ts @@ -634,7 +634,7 @@ describe('Article API', () => { const savedItem = await findLibraryItemByUrl(url, user.id) expect(savedItem?.archivedAt).to.not.be.null - expect(savedItem?.labels?.map((l) => l.name)).to.eql(labels) + expect(savedItem?.labels?.map((l) => l.name)).to.include.members(labels) }) }) diff --git a/packages/rss-handler/test/index.test.ts b/packages/rss-handler/test/index.test.ts index f5c7b7b38..6e21e1bfb 100644 --- a/packages/rss-handler/test/index.test.ts +++ b/packages/rss-handler/test/index.test.ts @@ -5,7 +5,7 @@ import { isOldItem, RssFeedItem } from '../src' describe('isOldItem', () => { it('returns true if item is older than 1 day', () => { const item = { - pubDate: '2020-01-01', + isoDate: '2020-01-01', } as RssFeedItem const mostRecentItemTimestamp = Date.now() @@ -15,7 +15,7 @@ describe('isOldItem', () => { it('returns true if item was published at the last fetched time', () => { const mostRecentItemTimestamp = Date.now() const item = { - pubDate: new Date(mostRecentItemTimestamp).toISOString(), + isoDate: new Date(mostRecentItemTimestamp).toISOString(), } as RssFeedItem expect(isOldItem(item, mostRecentItemTimestamp)).to.be.true