From 04868c1fd91da26977b3e9e134ddefa366ebc156 Mon Sep 17 00:00:00 2001 From: Sandy S Kuo <62935115+kuosandys@users.noreply.github.com> Date: Wed, 3 Jul 2024 20:55:14 +0200 Subject: [PATCH] fix: sort by highlight location when highlight position is equal --- packages/web/lib/highlights/sortHighlights.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/web/lib/highlights/sortHighlights.ts b/packages/web/lib/highlights/sortHighlights.ts index 3b90c5053..47604f91e 100644 --- a/packages/web/lib/highlights/sortHighlights.ts +++ b/packages/web/lib/highlights/sortHighlights.ts @@ -21,7 +21,11 @@ export function sortHighlights(highlights: Highlight[]) { return highlights .filter((h) => h.type === 'HIGHLIGHT') .sort((a: Highlight, b: Highlight) => { - if (a.highlightPositionPercent && b.highlightPositionPercent) { + if ( + a.highlightPositionPercent && + b.highlightPositionPercent && + a.highlightPositionPercent !== b.highlightPositionPercent + ) { return sorted(a.highlightPositionPercent, b.highlightPositionPercent) } // We do this in a try/catch because it might be an invalid diff