Benature/omnivore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #82 from omnivore-app/feature/bloomberg-newsletters

Browse Source 
Add support for Bloomberg newsletter
This commit is contained in:
Jackson Harper
2022-02-18 01:08:46 +08:00
committed by GitHub
parent f4854488c7 9431e80be8
commit 05aa5d737e
4 changed files with 70 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
packages/inbound-email-handler/src/newsletter.ts
View File

@ -6,9 +6,12 @@ const EMAIL_CONFIRMATION_CODE_RECEIVED_TOPIC = 'emailConfirmationCodeReceived'
const EMAIL_FORWARDING_SENDER_ADDRESSES = [
'Gmail Team <forwarding-noreply@google.com>',
]
const NEWSLETTER_SENDER_REGEX = '<.+@axios.com>'
const CONFIRMATION_CODE_PATTERN = '^\\(#\\d+\\)'
const AXIOS_URL_PATTERN = 'View in browser at <.+>'
const NEWSLETTER_SENDER_REGEX =
/<.+@((axios.com)|(mail.bloombergbusiness.com))>/
const CONFIRMATION_CODE_PATTERN = /^\\(#\\d+\\)/
const AXIOS_URL_PATTERN = /View in browser at <a.*>(.*)<\/a>/
const BLOOMBERG_URL_PATTERN =
/<a class="view-in-browser__url" href=["']([^"']*)["']/
export const handleConfirmation = async (email: string, subject: string) => {
console.log('confirmation email')
@ -114,11 +117,15 @@ export const getNewsletterUrl = (
}
// axios newsletter url from html
const re = new RegExp(AXIOS_URL_PATTERN)
const matches = html.match(re)
let matches = html.match(AXIOS_URL_PATTERN)
if (matches) {
const match = matches[0]
return match.slice(match.indexOf('>') + 1, match.lastIndexOf('<'))
return matches[1]
}
// bloomberg newsletter url from html
matches = html.match(BLOOMBERG_URL_PATTERN)
if (matches) {
return matches[1]
}
return undefined
}

22
packages/inbound-email-handler/test/newsletter.test.ts
View File

@ -28,6 +28,11 @@ describe('Newsletter email test', () => {
expect(isNewsletter('', from)).to.be.true
})
it('should return true when email is from bloomberg', () => {
const from = 'From: Bloomberg <noreply@mail.bloombergbusiness.com>'
expect(isNewsletter('', from)).to.be.true
})
})
describe('#getNewsletterUrl()', () => {
@ -41,10 +46,23 @@ describe('Newsletter email test', () => {
it('returns url when email is from Axios', () => {
const rawUrl = ''
const html = `View in browser at <a>https://axios.com/blog/2019/02/28/the-best-way-to-build-a-web-app</a>`
const html = `View in browser at <a>https://axios.com/blog/the-best-way-to-build-a-web-app</a>`
expect(getNewsletterUrl(rawUrl, html)).to.equal(
'https://axios.com/blog/2019/02/28/the-best-way-to-build-a-web-app'
'https://axios.com/blog/the-best-way-to-build-a-web-app'
)
})
it('returns url when email is from Bloomberg', () => {
const rawUrl = ''
const html = `
<a class="view-in-browser__url" href="https://www.bloomberg.com/news/google-is-now-a-partner">
View in browser
</a>
`
expect(getNewsletterUrl(rawUrl, html)).to.equal(
'https://www.bloomberg.com/news/google-is-now-a-partner'
)
})
})