From c939735678b3f43491eae7807a246769568e6f2c Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Fri, 22 Dec 2023 09:51:27 +0800 Subject: [PATCH] remove invalid-url error from subscribing feed --- packages/api/src/generated/graphql.ts | 1 - packages/api/src/generated/schema.graphql | 1 - packages/api/src/resolvers/subscriptions/index.ts | 10 ---------- packages/api/src/schema.ts | 1 - 4 files changed, 13 deletions(-) diff --git a/packages/api/src/generated/graphql.ts b/packages/api/src/generated/graphql.ts index f2fa24d95..62ba7be07 100644 --- a/packages/api/src/generated/graphql.ts +++ b/packages/api/src/generated/graphql.ts @@ -2790,7 +2790,6 @@ export enum SubscribeErrorCode { AlreadySubscribed = 'ALREADY_SUBSCRIBED', BadRequest = 'BAD_REQUEST', ExceededMaxSubscriptions = 'EXCEEDED_MAX_SUBSCRIPTIONS', - InvalidUrl = 'INVALID_URL', NotFound = 'NOT_FOUND', Unauthorized = 'UNAUTHORIZED' } diff --git a/packages/api/src/generated/schema.graphql b/packages/api/src/generated/schema.graphql index ac0db6c82..cbcdc1808 100644 --- a/packages/api/src/generated/schema.graphql +++ b/packages/api/src/generated/schema.graphql @@ -2190,7 +2190,6 @@ enum SubscribeErrorCode { ALREADY_SUBSCRIBED BAD_REQUEST EXCEEDED_MAX_SUBSCRIPTIONS - INVALID_URL NOT_FOUND UNAUTHORIZED } diff --git a/packages/api/src/resolvers/subscriptions/index.ts b/packages/api/src/resolvers/subscriptions/index.ts index 5ec3adc9f..173f1be1b 100644 --- a/packages/api/src/resolvers/subscriptions/index.ts +++ b/packages/api/src/resolvers/subscriptions/index.ts @@ -241,16 +241,6 @@ export const subscribeResolver = authorized< } } - if (feedUrl !== input.url) { - log.info('feed url is different from user provided url', { - feedUrl, - inputUrl: input.url, - }) - return { - errorCodes: [SubscribeErrorCode.InvalidUrl], - } - } - // create new rss subscription const MAX_RSS_SUBSCRIPTIONS = env.subscription.feed.max diff --git a/packages/api/src/schema.ts b/packages/api/src/schema.ts index ac1fdd125..4df9a5b35 100755 --- a/packages/api/src/schema.ts +++ b/packages/api/src/schema.ts @@ -1737,7 +1737,6 @@ const schema = gql` NOT_FOUND ALREADY_SUBSCRIBED EXCEEDED_MAX_SUBSCRIPTIONS - INVALID_URL } union AddPopularReadResult = AddPopularReadSuccess | AddPopularReadError