From 1b24a24f7c3eb8b0478b2d1fc30bd0c191601f1a Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Fri, 22 Mar 2024 17:20:37 +0800 Subject: [PATCH] remove slug from highlight event --- packages/api/src/services/highlights.ts | 6 ++---- packages/api/src/services/integrations/readwise.ts | 4 ++-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/packages/api/src/services/highlights.ts b/packages/api/src/services/highlights.ts index 57bb417b1..92fedc303 100644 --- a/packages/api/src/services/highlights.ts +++ b/packages/api/src/services/highlights.ts @@ -68,9 +68,8 @@ export const createHighlight = async ( EntityType.HIGHLIGHT, { id: libraryItemId, - slug: newHighlight.libraryItem.slug, - originalUrl: newHighlight.libraryItem.originalUrl, - thumbnail: newHighlight.libraryItem.thumbnail, + originalUrl: newHighlight.libraryItem.originalUrl, // for Readwise + thumbnail: newHighlight.libraryItem.thumbnail, // for Readwise highlights: [cleanData], }, userId @@ -122,7 +121,6 @@ export const mergeHighlights = async ( EntityType.HIGHLIGHT, { id: libraryItemId, - slug: newHighlight.libraryItem.slug, originalUrl: newHighlight.libraryItem.originalUrl, thumbnail: newHighlight.libraryItem.thumbnail, highlights: [newHighlight], diff --git a/packages/api/src/services/integrations/readwise.ts b/packages/api/src/services/integrations/readwise.ts index 001820837..129144ea1 100644 --- a/packages/api/src/services/integrations/readwise.ts +++ b/packages/api/src/services/integrations/readwise.ts @@ -101,14 +101,14 @@ export class ReadwiseClient implements IntegrationClient { text: highlight.quote, title: item.title, author: item.author || undefined, - highlight_url: getHighlightUrl(item.slug as string, highlight.id), + highlight_url: getHighlightUrl(item.id, highlight.id), highlighted_at: highlight.createdAt as string | undefined, category, image_url: item.thumbnail || undefined, location_type: 'order', note: highlight.annotation || undefined, source_type: 'omnivore', - source_url: item.originalUrl as string, + source_url: item.originalUrl, } }) : []