From 9f65588ba0cf93fc2009344a1505ca48ce8355a5 Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Sun, 21 Apr 2024 10:41:29 +0800 Subject: [PATCH 1/2] fix language and dir not saved for newsletters --- packages/api/src/services/save_email.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/api/src/services/save_email.ts b/packages/api/src/services/save_email.ts index 67792eb33..2ac020174 100644 --- a/packages/api/src/services/save_email.ts +++ b/packages/api/src/services/save_email.ts @@ -1,4 +1,8 @@ -import { LibraryItem, LibraryItemState } from '../entity/library_item' +import { + DirectionalityType, + LibraryItem, + LibraryItemState, +} from '../entity/library_item' import { enqueueThumbnailJob } from '../utils/createTask' import { cleanUrl, @@ -108,6 +112,8 @@ export const saveEmail = async ( subscription: input.author, folder: input.folder, labelNames: labels.map((label) => label.name), + itemLanguage: parseResult.parsedContent?.language, + directionality: parseResult.parsedContent?.dir as DirectionalityType, }, input.userId ) From dcf7c570c465b52a034e5c88d9cc83f0d9292073 Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Mon, 22 Apr 2024 10:57:48 +0800 Subject: [PATCH 2/2] fix tests --- packages/api/src/services/save_email.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/api/src/services/save_email.ts b/packages/api/src/services/save_email.ts index 2ac020174..821dfdca4 100644 --- a/packages/api/src/services/save_email.ts +++ b/packages/api/src/services/save_email.ts @@ -113,7 +113,8 @@ export const saveEmail = async ( folder: input.folder, labelNames: labels.map((label) => label.name), itemLanguage: parseResult.parsedContent?.language, - directionality: parseResult.parsedContent?.dir as DirectionalityType, + directionality: + (parseResult.parsedContent?.dir as DirectionalityType) || undefined, }, input.userId )