From b15a7b0bd5b63075bd8d50513b355d4dbb0ed161 Mon Sep 17 00:00:00 2001 From: Jackson Harper Date: Mon, 4 Apr 2022 09:15:56 -0700 Subject: [PATCH 1/2] Only install dev deps on the prod image --- packages/api/Dockerfile | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/api/Dockerfile b/packages/api/Dockerfile index 075958b7a..be7808b9b 100644 --- a/packages/api/Dockerfile +++ b/packages/api/Dockerfile @@ -2,7 +2,6 @@ FROM node:14.18-alpine as builder WORKDIR /app -ENV NODE_ENV development ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD true COPY package.json . @@ -14,16 +13,16 @@ COPY .eslintrc . COPY /packages/readabilityjs/package.json ./packages/readabilityjs/package.json COPY /packages/api/package.json ./packages/api/package.json -RUN yarn install --pure-lockfile --development +RUN yarn install --pure-lockfile ADD /packages/readabilityjs ./packages/readabilityjs ADD /packages/api ./packages/api RUN yarn +RUN yarn clean RUN yarn workspace @omnivore/api build - FROM node:14.18-alpine as runner WORKDIR /app @@ -35,10 +34,9 @@ ENV PORT=8080 COPY --from=builder /app/packages/api/dist /app/packages/api/dist COPY --from=builder /app/packages/readabilityjs/ /app/packages/readabilityjs/ COPY --from=builder /app/packages/api/package.json /app/packages/api/package.json -COPY --from=builder /app/packages/api/node_modules /app/packages/api/node_modules -COPY --from=builder /app/node_modules /app/node_modules COPY --from=builder /app/package.json /app/package.json COPY --from=builder /app/packages/api/index_settings.json /app/packages/api/index_settings.json +RUN yarn install --production EXPOSE 8080 From bd6bed746e6575bdf07c5e32ef55e144b8418e46 Mon Sep 17 00:00:00 2001 From: Jackson Harper Date: Mon, 4 Apr 2022 09:19:25 -0700 Subject: [PATCH 2/2] Remove clean command --- packages/api/Dockerfile | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/api/Dockerfile b/packages/api/Dockerfile index be7808b9b..5bc4b9e2b 100644 --- a/packages/api/Dockerfile +++ b/packages/api/Dockerfile @@ -19,7 +19,6 @@ ADD /packages/readabilityjs ./packages/readabilityjs ADD /packages/api ./packages/api RUN yarn -RUN yarn clean RUN yarn workspace @omnivore/api build