Benature/omnivore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

use private bucket to upload page events (#244)

Browse Source 
* use private bucket to upload page events

* fix tests

* add GCS_UPLOAD_PRIVATE_BUCKET in test env

* allow GCS_UPLOAD_PRIVATE_BUCKET to be empty
This commit is contained in:
Hongbo Wu
2022-03-16 14:39:07 +08:00
committed by GitHub
parent 48e0a69931
commit 27157006c1
10 changed files with 37 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/api/src/util.ts
View File

@ -65,6 +65,7 @@ interface BackendEnv {
fileUpload: {
gcsUploadBucket: string
gcsUploadSAKeyFilePath: string
gcsUploadPrivateBucket: string
}
elastic: {
url: string
@ -110,6 +111,7 @@ const nullableEnvVars = [
'TWITTER_BEARER_TOKEN',
'ELASTIC_USERNAME',
'ELASTIC_PASSWORD',
'GCS_UPLOAD_PRIVATE_BUCKET',
] // Allow some vars to be null/empty
/* If not in GAE and Prod/QA/Demo env (f.e. on localhost/dev env), allow following env vars to be null */
@ -202,6 +204,7 @@ export function getEnv(): BackendEnv {
const fileUpload = {
gcsUploadBucket: parse('GCS_UPLOAD_BUCKET'),
gcsUploadSAKeyFilePath: parse('GCS_UPLOAD_SA_KEY_FILE_PATH'),
gcsUploadPrivateBucket: parse('GCS_UPLOAD_PRIVATE_BUCKET'),
}
const elastic = {
url: parse('ELASTIC_URL'),