From 29bbba48c5be4be782dbcec75aa76cdc81d15d9d Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Fri, 23 Aug 2024 17:07:05 +0800
Subject: [PATCH] process rule sequentially

---
 packages/api/src/jobs/trigger_rule.ts | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/packages/api/src/jobs/trigger_rule.ts b/packages/api/src/jobs/trigger_rule.ts
index 27b3a6a64..4ea469706 100644
--- a/packages/api/src/jobs/trigger_rule.ts
+++ b/packages/api/src/jobs/trigger_rule.ts
@@ -222,8 +222,6 @@ const triggerActions = async (
   data: ItemEvent,
   ruleEventType: RuleEventType
 ) => {
-  const actionPromises: Promise<unknown>[] = []
-
   for (const rule of rules) {
     let ast: LiqeQuery
     let results: (ItemEvent | LibraryItem)[]
@@ -276,15 +274,13 @@ const triggerActions = async (
         ruleEventType,
       }
 
-      actionPromises.push(actionFunc(actionObj))
+      try {
+        await actionFunc(actionObj)
+      } catch (error) {
+        logger.error('Error triggering rule action', error)
+      }
     }
   }
-
-  try {
-    await Promise.all(actionPromises)
-  } catch (error) {
-    logger.error('Error triggering rule actions', error)
-  }
 }
 
 export const triggerRule = async (jobData: TriggerRuleJobData) => {