From 2c10068c2ab2b677d136c056d77de60cceab9e85 Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Thu, 9 Mar 2023 15:06:28 +0800
Subject: [PATCH] Add checking for the emptiness of event types

---
 packages/web/pages/settings/webhooks.tsx | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/packages/web/pages/settings/webhooks.tsx b/packages/web/pages/settings/webhooks.tsx
index 4769351f9..777066ed5 100644
--- a/packages/web/pages/settings/webhooks.tsx
+++ b/packages/web/pages/settings/webhooks.tsx
@@ -62,6 +62,14 @@ export default function Webhooks(): JSX.Element {
 
   applyStoredTheme(false)
 
+  function validateEventTypes(eventTypes: WebhookEvent[]): boolean {
+    if (eventTypes.length > 0) return true
+    showErrorToast('Please select at least one event type', {
+      position: 'bottom-right',
+    })
+    return false
+  }
+
   async function onDelete(id: string): Promise<void> {
     const result = await deleteWebhookMutation(id)
     if (result) {
@@ -73,6 +81,7 @@ export default function Webhooks(): JSX.Element {
   }
 
   async function onCreate(): Promise<void> {
+    if (!validateEventTypes(eventTypes)) return
     const result = await setWebhookMutation({ url, eventTypes })
     if (result) {
       showSuccessToast('Webhook created', { position: 'bottom-right' })
@@ -83,6 +92,7 @@ export default function Webhooks(): JSX.Element {
   }
 
   async function onUpdate(): Promise<void> {
+    if (!validateEventTypes(eventTypes)) return
     const result = await setWebhookMutation({
       id: onEditWebhook?.id,
       url,