From 3a65ee3a6caf082f3b9f75f463cda899e1230594 Mon Sep 17 00:00:00 2001 From: Thomas Rogers Date: Fri, 1 Sep 2023 18:30:29 +0200 Subject: [PATCH 1/2] Fix Loading: Ensure that image is loaded when retrieving images --- .../web/components/templates/homeFeed/HomeFeedContainer.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/web/components/templates/homeFeed/HomeFeedContainer.tsx b/packages/web/components/templates/homeFeed/HomeFeedContainer.tsx index 65c1bb689..26b2b8e24 100644 --- a/packages/web/components/templates/homeFeed/HomeFeedContainer.tsx +++ b/packages/web/components/templates/homeFeed/HomeFeedContainer.tsx @@ -224,7 +224,7 @@ export function HomeFeedContainer(): JSX.Element { if (link && link.state != 'PROCESSING') { const updatedArticle = { ...item } - updatedArticle.node = { ...item.node, ...link } + updatedArticle.node = { ...item.node, ...link, image: "https://cdn.arstechnica.net/wp-content/uploads/2023/09/cpglitch-800x450.jpg" } updatedArticle.isLoading = false console.log(`Updating Metadata of ${item.node.slug}.`) performActionOnItem('update-item', updatedArticle) @@ -1229,7 +1229,7 @@ function LibraryItems(props: LibraryItemsProps): JSX.Element { data-testid="linkedItemCard" id={linkedItem.node.id} tabIndex={0} - key={linkedItem.node.id} + key={linkedItem.node.id + linkedItem.node.image} css={{ width: '100%', '&:focus-visible': { From f85ec33ec74f9d81d7b6334c67c40a3d83d8defc Mon Sep 17 00:00:00 2001 From: Thomas Rogers Date: Fri, 1 Sep 2023 18:32:30 +0200 Subject: [PATCH 2/2] Remove Placeholder Image --- .../web/components/templates/homeFeed/HomeFeedContainer.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/web/components/templates/homeFeed/HomeFeedContainer.tsx b/packages/web/components/templates/homeFeed/HomeFeedContainer.tsx index 26b2b8e24..fae67ae68 100644 --- a/packages/web/components/templates/homeFeed/HomeFeedContainer.tsx +++ b/packages/web/components/templates/homeFeed/HomeFeedContainer.tsx @@ -224,7 +224,7 @@ export function HomeFeedContainer(): JSX.Element { if (link && link.state != 'PROCESSING') { const updatedArticle = { ...item } - updatedArticle.node = { ...item.node, ...link, image: "https://cdn.arstechnica.net/wp-content/uploads/2023/09/cpglitch-800x450.jpg" } + updatedArticle.node = { ...item.node, ...link } updatedArticle.isLoading = false console.log(`Updating Metadata of ${item.node.slug}.`) performActionOnItem('update-item', updatedArticle)