From 0b2b93384f636c242ae40506f2ccfade638e8a26 Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Mon, 18 Apr 2022 20:45:06 +0800
Subject: [PATCH] fix return undefined as updateLabelResult

---
 packages/api/src/resolvers/labels/index.ts | 25 ++++++++++------------
 1 file changed, 11 insertions(+), 14 deletions(-)

diff --git a/packages/api/src/resolvers/labels/index.ts b/packages/api/src/resolvers/labels/index.ts
index b86a1ae42..a61ba82c8 100644
--- a/packages/api/src/resolvers/labels/index.ts
+++ b/packages/api/src/resolvers/labels/index.ts
@@ -288,9 +288,16 @@ export const updateLabelResolver = authorized<
       }
     }
 
+    log.info('Updating a label', {
+      labels: {
+        source: 'resolver',
+        resolver: 'updateLabelResolver',
+      },
+    })
+
     const result = await AppDataSource.transaction(async (t) => {
       await setClaims(t, uid)
-      return await t.getRepository(Label).update(
+      return t.getRepository(Label).update(
         { id: labelId },
         {
           name: name,
@@ -300,23 +307,13 @@ export const updateLabelResolver = authorized<
       )
     })
 
-    log.info('Updating a label', {
-      result,
-      labels: {
-        source: 'resolver',
-        resolver: 'updateLabelResolver',
-      },
-    })
-
-    if (!result) {
-      log.info('failed to update')
+    if (!result.affected) {
+      log.error('failed to update')
       return {
-        errorCodes: [UpdateLabelErrorCode.BadRequest],
+        errorCodes: [UpdateLabelErrorCode.NotFound],
       }
     }
 
-    log.info('updated successfully')
-
     return { label: label }
   } catch (error) {
     log.error('error updating label', error)