From 22850bb6aba14933f56a5bb12f7c47abc994c30f Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Thu, 18 Apr 2024 14:04:38 +0800 Subject: [PATCH 1/2] return UNKNOWN if email exists when user signs up --- packages/api/src/services/create_user.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/api/src/services/create_user.ts b/packages/api/src/services/create_user.ts index c71da06cd..a52b76c22 100644 --- a/packages/api/src/services/create_user.ts +++ b/packages/api/src/services/create_user.ts @@ -37,7 +37,7 @@ export const createUser = async (input: { const existingUser = await userRepository.findByEmail(trimmedEmail) if (existingUser) { if (existingUser.profile) { - return Promise.reject({ errorCode: SignupErrorCode.UserExists }) + return Promise.reject({ errorCode: SignupErrorCode.Unknown }) } // create profile if user exists but profile does not exist From 75c0745d7e6d181f91a4b9fa0f8ba1569ee6aa12 Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Fri, 19 Apr 2024 11:19:39 +0800 Subject: [PATCH 2/2] fix tests --- packages/api/test/routers/auth.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/api/test/routers/auth.test.ts b/packages/api/test/routers/auth.test.ts index 8bfd3e5e4..32b438047 100644 --- a/packages/api/test/routers/auth.test.ts +++ b/packages/api/test/routers/auth.test.ts @@ -90,12 +90,12 @@ describe('auth router', () => { await deleteUser(user.id) }) - it('redirects to sign up page with error code USER_EXISTS', async () => { + it('redirects to sign up page with error code UNKNOWN', async () => { const res = await signupRequest(email, password, name, username).expect( 302 ) expect(res.header.location).to.endWith( - '/email-signup?errorCodes=USER_EXISTS' + '/email-signup?errorCodes=UNKNOWN' ) }) })