From 3f14ac4f9b0da3ddafe01761a0b5daeba91b6845 Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Mon, 23 Oct 2023 21:31:38 +0800
Subject: [PATCH] skip publishing event for importing

---
 packages/api/src/services/library_item.ts | 7 ++++++-
 packages/api/src/services/save_page.ts    | 8 ++++++--
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/packages/api/src/services/library_item.ts b/packages/api/src/services/library_item.ts
index e662ecb69..7fec735e0 100644
--- a/packages/api/src/services/library_item.ts
+++ b/packages/api/src/services/library_item.ts
@@ -527,7 +527,8 @@ export const createLibraryItems = async (
 export const createLibraryItem = async (
   libraryItem: DeepPartial<LibraryItem>,
   userId: string,
-  pubsub = createPubSubClient()
+  pubsub = createPubSubClient(),
+  skipPubSub = false
 ): Promise<LibraryItem> => {
   const newLibraryItem = await authTrx(
     async (tx) =>
@@ -541,6 +542,10 @@ export const createLibraryItem = async (
     userId
   )
 
+  if (skipPubSub) {
+    return newLibraryItem
+  }
+
   await pubsub.entityCreated<DeepPartial<LibraryItem>>(
     EntityType.PAGE,
     {
diff --git a/packages/api/src/services/save_page.ts b/packages/api/src/services/save_page.ts
index 68af11b2c..e14ca4850 100644
--- a/packages/api/src/services/save_page.ts
+++ b/packages/api/src/services/save_page.ts
@@ -7,7 +7,6 @@ import { User } from '../entity/user'
 import { homePageURL } from '../env'
 import {
   ArticleSavingRequestStatus,
-  HighlightType,
   Maybe,
   PreparedDocumentInput,
   SaveErrorCode,
@@ -144,7 +143,12 @@ export const savePage = async (
       )
     } else {
       // do not publish a pubsub event if the item is imported
-      const newItem = await createLibraryItem(itemToSave, user.id)
+      const newItem = await createLibraryItem(
+        itemToSave,
+        user.id,
+        undefined,
+        isImported
+      )
       clientRequestId = newItem.id
     }