From 4678d6f473b3b01d39fcb77a59d1a695a2173f8c Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Thu, 8 Jun 2023 13:33:59 +0800
Subject: [PATCH] check label uniqueness by name

---
 packages/api/src/elastic/pages.ts | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/packages/api/src/elastic/pages.ts b/packages/api/src/elastic/pages.ts
index 5c26cb16e..b2d28cb78 100644
--- a/packages/api/src/elastic/pages.ts
+++ b/packages/api/src/elastic/pages.ts
@@ -709,7 +709,7 @@ export const updatePagesAsync = async (
   switch (action) {
     case BulkActionType.Archive:
       script = {
-        source: `ctx._source.archivedAt = params.archivedAt`,
+        source: `ctx._source.archivedAt = params.archivedAt;`,
         params: {
           archivedAt: new Date(),
         },
@@ -717,7 +717,7 @@ export const updatePagesAsync = async (
       break
     case BulkActionType.Delete:
       script = {
-        source: `ctx._source.state = params.state`,
+        source: `ctx._source.state = params.state;`,
         params: {
           state: ArticleSavingRequestStatus.Deleted,
         },
@@ -728,9 +728,12 @@ export const updatePagesAsync = async (
         source: `if (ctx._source.labels == null) {
           ctx._source.labels = params.labels
         } else {
-          ctx._source.labels.addAll(params.labels)
-        }
-        ctx._source.labels.unique()`,
+          for (label in params.labels) {
+            if (!ctx._source.labels.any(l -> l.name == label.name)) {
+              ctx._source.labels.add(label)
+            }
+          }
+        }`,
         params: {
           labels,
         },
@@ -752,7 +755,7 @@ export const updatePagesAsync = async (
 
   // add updatedAt to the script
   const updatedScript = {
-    source: `${script.source}; ctx._source.updatedAt = params.updatedAt`,
+    source: `${script.source} ctx._source.updatedAt = params.updatedAt`,
     lang: 'painless',
     params: {
       ...script.params,