From 291bb5924889310763bc667d1a90429da24e7f7a Mon Sep 17 00:00:00 2001
From: Jackson Harper <jacksonh@gmail.com>
Date: Thu, 21 Jul 2022 17:29:55 -0700
Subject: [PATCH 1/2] Add name attribiutes to email login form elements

---
 packages/web/components/templates/EmailLogin.tsx | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/packages/web/components/templates/EmailLogin.tsx b/packages/web/components/templates/EmailLogin.tsx
index e8a8962bd..f644974dd 100644
--- a/packages/web/components/templates/EmailLogin.tsx
+++ b/packages/web/components/templates/EmailLogin.tsx
@@ -52,6 +52,7 @@ export function EmailLogin(): JSX.Element {
             <BorderedFormInput
               key="email"
               type="text"
+              name="email"
               value={email}
               placeholder="Email"
               onChange={(e) => { e.preventDefault(); setEmail(e.target.value); }}
@@ -63,6 +64,7 @@ export function EmailLogin(): JSX.Element {
             <BorderedFormInput
               key="password"
               type="password"
+              name="password"
               value={password}
               placeholder="Password"
               onChange={(e) => setPassword(e.target.value)}

From c113c94567b9779ea416ea95ec886f58c7201b46 Mon Sep 17 00:00:00 2001
From: Jackson Harper <jacksonh@gmail.com>
Date: Thu, 21 Jul 2022 17:43:15 -0700
Subject: [PATCH 2/2] Add param validation so we dont get undefined values
 passed to GQL

---
 packages/api/src/routers/auth/auth_router.ts | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/packages/api/src/routers/auth/auth_router.ts b/packages/api/src/routers/auth/auth_router.ts
index b3d8853b6..d9289111e 100644
--- a/packages/api/src/routers/auth/auth_router.ts
+++ b/packages/api/src/routers/auth/auth_router.ts
@@ -356,6 +356,11 @@ export function authRouter() {
     cors<express.Request>(corsConfig),
     async (req: express.Request, res: express.Response) => {
       const { email, password } = req.body
+      if (!email || !password) {
+        res.redirect(`${env.client.url}/email-login?errorCodes=AUTH_FAILED`)
+        return
+      }
+
       const query = `
       mutation login{
         login(input: {
@@ -418,6 +423,11 @@ export function authRouter() {
     cors<express.Request>(corsConfig),
     async (req: express.Request, res: express.Response) => {
       const { email, password, name, username, bio } = req.body
+      if (!email || !password || !name || !username) {
+        res.redirect(`${env.client.url}/email-signup?errorCodes=BAD_DATA`)
+        return
+      }
+
       const query = `
       mutation signup {
         signup(input: {
@@ -425,7 +435,7 @@ export function authRouter() {
           password: "${password}",
           name: "${name}",
           username: "${username}",
-          bio: "${bio}"
+          bio: "${bio ?? ''}"
         }) {
           __typename
           ... on SignupSuccess {