From 1243e2ace2e4ab629e2d0d23f3bf42ed60154a12 Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Tue, 10 Jan 2023 11:17:22 +0800
Subject: [PATCH] Fix the error when no name in subscription by using the email
 address as the author when no author found in the newsletter

---
 packages/content-handler/src/content-handler.ts  | 2 +-
 packages/content-handler/test/newsletter.test.ts | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/packages/content-handler/src/content-handler.ts b/packages/content-handler/src/content-handler.ts
index a05e2ac1a..83a5b7e35 100644
--- a/packages/content-handler/src/content-handler.ts
+++ b/packages/content-handler/src/content-handler.ts
@@ -134,7 +134,7 @@ export abstract class ContentHandler {
     // e.g. 'Jackson Harper from Omnivore App <jacksonh@substack.com>'
     // or 'Mike Allen <mike@axios.com>'
     const parsed = addressparser(from)
-    if (parsed.length > 0) {
+    if (parsed.length > 0 && parsed[0].name) {
       return parsed[0].name
     }
     return from
diff --git a/packages/content-handler/test/newsletter.test.ts b/packages/content-handler/test/newsletter.test.ts
index 9d859a1dd..5e64655ca 100644
--- a/packages/content-handler/test/newsletter.test.ts
+++ b/packages/content-handler/test/newsletter.test.ts
@@ -93,6 +93,11 @@ describe('Newsletter email test', () => {
       const from = 'Mike Allen <mike@axios.com>'
       expect(new AxiosHandler().parseAuthor(from)).to.equal('Mike Allen')
     })
+
+    it('returns email address if author is not there', () => {
+      const from = 'mike@axios.com'
+      expect(new AxiosHandler().parseAuthor(from)).to.equal(from)
+    })
   })
 
   describe('getNewsletterHandler', () => {