Remove focus when dropdown closed, fix light theme border colours for label picker

This commit is contained in:
Jackson Harper
2023-06-20 17:24:52 +08:00
parent a49e4f0378
commit 5f5d3ca164
4 changed files with 7 additions and 5 deletions

View File

@ -185,6 +185,9 @@ export function Dropdown(
sideOffset={sideOffset}
align={align ? align : 'center'}
alignOffset={alignOffset}
onCloseAutoFocus={(event) => {
event.preventDefault()
}}
>
{labelText && <StyledLabel>{labelText}</StyledLabel>}
{children}

View File

@ -48,7 +48,7 @@ export const LabelsPicker = (props: LabelsPickerProps): JSX.Element => {
if (!isTouchScreenDevice() && focused && inputRef.current) {
inputRef.current.focus()
}
}, [focused])
}, [inputRef.current, focused])
const autoComplete = useCallback(() => {
const lowerCasedValue = inputValue.toLowerCase()
@ -124,7 +124,7 @@ export const LabelsPicker = (props: LabelsPickerProps): JSX.Element => {
},
'&:focus-within': {
outline: 'none',
border: '1px solid $thLibraryMenuUnselected',
border: '1px solid #898989',
},
'>span': {
marginTop: '0px',

View File

@ -241,9 +241,7 @@ export function SetLabelsControl(props: SetLabelsControlProps): JSX.Element {
props
const { labels, revalidate } = useGetLabelsQuery()
// Move focus through the labels list on tab or arrow up/down keys
const [focusedIndex, setFocusedIndex] = useState<number | undefined>(
undefined
)
const [focusedIndex, setFocusedIndex] = useState<number | undefined>(0)
useEffect(() => {
setFocusedIndex(undefined)

View File

@ -173,6 +173,7 @@ export function SetLabelsModal(props: SetLabelsModalProps): JSX.Element {
<ModalRoot defaultOpen onOpenChange={props.onOpenChange}>
<ModalOverlay />
<ModalContent
tabIndex={0}
css={{
border: '1px solid $grayBorder',
backgroundColor: '$thBackground',