From ebfdf1f3a027641cff284698fa78570b7f448797 Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Thu, 21 Apr 2022 21:28:00 +0800 Subject: [PATCH 1/2] Fix parsing newsletter url from substack --- packages/inbound-email-handler/src/substack-handler.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/inbound-email-handler/src/substack-handler.ts b/packages/inbound-email-handler/src/substack-handler.ts index 9c676f25c..10160b76e 100644 --- a/packages/inbound-email-handler/src/substack-handler.ts +++ b/packages/inbound-email-handler/src/substack-handler.ts @@ -7,7 +7,7 @@ export class SubstackHandler extends NewsletterHandler { this.defaultUrl = 'https://www.substack.com' } - getNewsletterUrl(postHeader: string, _html: string): string | undefined { + parseNewsletterUrl(postHeader: string, _html: string): string | undefined { // raw SubStack newsletter url is like // we need to get the real url from the raw url return addressparser(postHeader).length > 0 From 6d2700e865bed4827df6f0d06956aec42bb7d316 Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Thu, 21 Apr 2022 21:31:31 +0800 Subject: [PATCH 2/2] fix tests --- packages/inbound-email-handler/test/newsletter.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/inbound-email-handler/test/newsletter.test.ts b/packages/inbound-email-handler/test/newsletter.test.ts index 81d6f31d6..dba9f0952 100644 --- a/packages/inbound-email-handler/test/newsletter.test.ts +++ b/packages/inbound-email-handler/test/newsletter.test.ts @@ -83,7 +83,7 @@ describe('Newsletter email test', () => { it('returns url when email is from SubStack', () => { const rawUrl = '' - expect(new SubstackHandler().getNewsletterUrl(rawUrl, '')).to.equal( + expect(new SubstackHandler().parseNewsletterUrl(rawUrl, '')).to.equal( 'https://hongbo130.substack.com/p/tldr' ) })