From 1d81398bbd06b19f3702819a67ee3db4b7253046 Mon Sep 17 00:00:00 2001 From: Jackson Harper Date: Tue, 24 Jan 2023 20:03:53 +0800 Subject: [PATCH 1/2] Improve logging on errors in the importer tool --- packages/import-handler/src/index.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/import-handler/src/index.ts b/packages/import-handler/src/index.ts index 3333d56df..ded094b5d 100644 --- a/packages/import-handler/src/index.ts +++ b/packages/import-handler/src/index.ts @@ -166,7 +166,6 @@ const sendSavePageMutation = async (userId: string, input: unknown) => { 'Content-Type': 'application/json', }, }) - console.log('save page response: ', response) /* eslint-disable @typescript-eslint/no-unsafe-member-access */ return !!response.data.data.savePage @@ -256,7 +255,12 @@ export const importHandler = Sentry.GCPFunction.wrapHttpFunction( const pubSubMessage = req.body.message.data as string const obj = getStorageEvent(pubSubMessage) if (obj) { - await handleEvent(obj) + try { + await handleEvent(obj) + } catch (err) { + console.log('error handling event', { err, obj }) + throw err + } } } else { console.log('no pubsub message') From 46e371bc266f30523bd871c88e195183a478bd09 Mon Sep 17 00:00:00 2001 From: Jackson Harper Date: Tue, 24 Jan 2023 20:36:34 +0800 Subject: [PATCH 2/2] Remove more debug --- packages/import-handler/src/task.ts | 9 --------- 1 file changed, 9 deletions(-) diff --git a/packages/import-handler/src/task.ts b/packages/import-handler/src/task.ts index 16f66b08d..f4873376d 100644 --- a/packages/import-handler/src/task.ts +++ b/packages/import-handler/src/task.ts @@ -29,15 +29,6 @@ export const createCloudTask = async ( const serviceAccountEmail = `${project}@appspot.gserviceaccount.com` const parent = cloudTask.queuePath(project, location, queue) - console.log(`Task creation options: `, { - project, - location, - queue, - taskHandlerUrl, - serviceAccountEmail, - payload, - }) - const convertedPayload = JSON.stringify(payload) const body = Buffer.from(convertedPayload).toString('base64') const task: protos.google.cloud.tasks.v2.ITask = {