From 8834efabd46789e52434e57ab5c02092e5581f8a Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Wed, 24 Jan 2024 19:09:18 +0800
Subject: [PATCH] throw error if save-page job failed

---
 packages/api/src/jobs/save_page.ts     |  2 +-
 packages/api/src/services/save_page.ts | 14 +++++++++-----
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/packages/api/src/jobs/save_page.ts b/packages/api/src/jobs/save_page.ts
index 3d143caf8..0e87eb30c 100644
--- a/packages/api/src/jobs/save_page.ts
+++ b/packages/api/src/jobs/save_page.ts
@@ -360,7 +360,7 @@ export const savePageJob = async (data: Data, attemptsMade: number) => {
     )
 
     if (result.__typename == 'SaveError') {
-      throw new Error(result.message || 'Failed to save page')
+      throw new Error(result.message || result.errorCodes[0])
     }
 
     isImported = true
diff --git a/packages/api/src/services/save_page.ts b/packages/api/src/services/save_page.ts
index 9d55961e7..7931fc48e 100644
--- a/packages/api/src/services/save_page.ts
+++ b/packages/api/src/services/save_page.ts
@@ -112,6 +112,7 @@ export const savePage = async (
       })
     } catch (e) {
       return {
+        __typename: 'SaveError',
         errorCodes: [SaveErrorCode.Unknown],
         message: 'Failed to create page save request',
       }
@@ -183,11 +184,14 @@ export const savePage = async (
       libraryItem: { id: clientRequestId },
     }
 
-    if (!(await createHighlight(highlight, clientRequestId, user.id))) {
-      return {
-        errorCodes: [SaveErrorCode.EmbeddedHighlightFailed],
-        message: 'Failed to save highlight',
-      }
+    try {
+      await createHighlight(highlight, clientRequestId, user.id)
+    } catch (error) {
+      logger.error('Failed to create highlight', {
+        highlight,
+        clientRequestId,
+        userId: user.id,
+      })
     }
   }