From f7c814d58420cc3828e70644883c56b78797ab42 Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Thu, 16 Jun 2022 18:05:02 +0800 Subject: [PATCH 1/2] Add yarn to volta --- package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 4985ac42d..4daf72d28 100644 --- a/package.json +++ b/package.json @@ -36,6 +36,7 @@ "typescript": "^4.4.3" }, "volta": { - "node": "14.18.1" + "node": "14.18.1", + "yarn": "1.22.19" } } From 8535534709a0bbc59aede9e023a845da4a1b62e1 Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Thu, 16 Jun 2022 18:09:23 +0800 Subject: [PATCH 2/2] Fix classname = null exception by checking element parent node nullability before checking classname --- packages/readabilityjs/Readability.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/readabilityjs/Readability.js b/packages/readabilityjs/Readability.js index 3d2a2931d..13e1791ad 100644 --- a/packages/readabilityjs/Readability.js +++ b/packages/readabilityjs/Readability.js @@ -2235,7 +2235,7 @@ Readability.prototype = { if (tweetParent && tweetParent.className.includes('twitter-tweet')) { tweetParent.parentNode.replaceChild(tweet, tweetParent); } - } else if (element.parentNode.className === 'tweet') { + } else if (element.parentNode && element.parentNode.className === 'tweet') { // Create tweets placeholders from classname try { const response = await axios.get(link);