From e1e81a41c25e5a04b77a3b946ce54b165f4598f0 Mon Sep 17 00:00:00 2001 From: Jackson Harper Date: Mon, 9 Oct 2023 17:27:22 +0800 Subject: [PATCH] Fix the filter in the left menu do not create a dependency loop --- .../components/templates/homeFeed/LibraryFilterMenu.tsx | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/web/components/templates/homeFeed/LibraryFilterMenu.tsx b/packages/web/components/templates/homeFeed/LibraryFilterMenu.tsx index c7beed680..ff113ea3d 100644 --- a/packages/web/components/templates/homeFeed/LibraryFilterMenu.tsx +++ b/packages/web/components/templates/homeFeed/LibraryFilterMenu.tsx @@ -65,9 +65,9 @@ export function LibraryFilterMenu(props: LibraryFilterMenuProps): JSX.Element { useEffect(() => { if (!subscriptionsLoading) { - setSubscriptions(networkSubscriptions.filter((s) => s.status == 'ACTIVE')) + setSubscriptions(networkSubscriptions) } - }, [setSubscriptions, networkLabels, subscriptionsLoading]) + }, [setSubscriptions, networkSubscriptions, subscriptionsLoading]) useEffect(() => { if (!searchesLoading) { @@ -204,7 +204,9 @@ function Subscriptions( if (!props.subscriptions) { return [] } - return props.subscriptions.sort((a, b) => a.name.localeCompare(b.name)) + return props.subscriptions + .filter((s) => s.status == 'ACTIVE') + .sort((a, b) => a.name.localeCompare(b.name)) }, [props.subscriptions]) useRegisterActions(