From a3396997b2af33fb261cac7ee96b46c5cd69e575 Mon Sep 17 00:00:00 2001
From: Jackson Harper <jacksonh@gmail.com>
Date: Wed, 1 Feb 2023 17:38:43 +0800
Subject: [PATCH] Handle PDF diffs when sorting the notebook

---
 .../components/templates/article/NotebookModal.tsx | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/packages/web/components/templates/article/NotebookModal.tsx b/packages/web/components/templates/article/NotebookModal.tsx
index a629f6fdf..52a6c19eb 100644
--- a/packages/web/components/templates/article/NotebookModal.tsx
+++ b/packages/web/components/templates/article/NotebookModal.tsx
@@ -66,11 +66,15 @@ export function NotebookModal(props: NotebookModalProps): JSX.Element {
       if (a.highlightPositionPercent && b.highlightPositionPercent) {
         return sorted(a.highlightPositionPercent, b.highlightPositionPercent)
       }
-      const aPos = getHighlightLocation(a.patch)
-      const bPos = getHighlightLocation(b.patch)
-      if (aPos && bPos) {
-        return sorted(aPos, bPos)
-      }
+      // We do this in a try/catch because it might be an invalid diff
+      // With PDF it will definitely be an invalid diff.
+      try {
+        const aPos = getHighlightLocation(a.patch)
+        const bPos = getHighlightLocation(b.patch)
+        if (aPos && bPos) {
+          return sorted(aPos, bPos)
+        }
+      } catch {}
       return a.createdAt.localeCompare(b.createdAt)
     })
   }, [props.highlights])