From 56b87672fd04ca0031f8a9c4de06f0c406bc0a81 Mon Sep 17 00:00:00 2001 From: Justin Maximillian Kimlim Date: Tue, 16 Apr 2024 00:49:26 +0700 Subject: [PATCH 1/2] feat: increase daily upload limit --- .../api/src/resolvers/importers/uploadImportFileResolver.ts | 2 +- packages/api/src/util.ts | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/api/src/resolvers/importers/uploadImportFileResolver.ts b/packages/api/src/resolvers/importers/uploadImportFileResolver.ts index 0a1c0dd53..40d0fc529 100644 --- a/packages/api/src/resolvers/importers/uploadImportFileResolver.ts +++ b/packages/api/src/resolvers/importers/uploadImportFileResolver.ts @@ -16,7 +16,6 @@ import { generateUploadSignedUrl, } from '../../utils/uploads' -const MAX_DAILY_UPLOADS = 1 const VALID_CONTENT_TYPES = ['text/csv', 'application/zip'] const extensionForContentType = (contentType: string) => { @@ -61,6 +60,7 @@ export const uploadImportFileResolver = authorized< const dirPath = `imports/${uid}/${dateStr}/` const fileCount = await countOfFilesWithPrefix(dirPath) + const MAX_DAILY_UPLOADS = env.fileUpload.dailyUploadLimit if (fileCount >= MAX_DAILY_UPLOADS) { return { errorCodes: [UploadImportFileErrorCode.UploadDailyLimitExceeded], diff --git a/packages/api/src/util.ts b/packages/api/src/util.ts index d42f84ce1..9e915032a 100755 --- a/packages/api/src/util.ts +++ b/packages/api/src/util.ts @@ -81,6 +81,7 @@ export interface BackendEnv { gcsUploadBucket: string gcsUploadSAKeyFilePath: string gcsUploadPrivateBucket: string + dailyUploadLimit: number } sender: { message: string @@ -144,6 +145,7 @@ const nullableEnvVars = [ 'POSTHOG_API_KEY', 'TWITTER_BEARER_TOKEN', 'GCS_UPLOAD_PRIVATE_BUCKET', + 'GCS_UPLOAD_DAILY_LIMIT', 'SENDER_MESSAGE', 'SENDER_FEEDBACK', 'SENDER_GENERAL', @@ -275,6 +277,9 @@ export function getEnv(): BackendEnv { gcsUploadBucket: parse('GCS_UPLOAD_BUCKET'), gcsUploadSAKeyFilePath: parse('GCS_UPLOAD_SA_KEY_FILE_PATH'), gcsUploadPrivateBucket: parse('GCS_UPLOAD_PRIVATE_BUCKET'), + dailyUploadLimit: parse('GCS_UPLOAD_DAILY_LIMIT') + ? parseInt(parse('GCS_UPLOAD_DAILY_LIMIT'), 10) + : 30, // default to 30 } const sender = { message: parse('SENDER_MESSAGE'), From 636fa177127455e7b58f21f71b1a5e4ac3d9b145 Mon Sep 17 00:00:00 2001 From: Jackson Harper Date: Wed, 24 Apr 2024 16:39:46 -0700 Subject: [PATCH 2/2] Default to 5 items --- packages/api/src/util.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/api/src/util.ts b/packages/api/src/util.ts index 9e915032a..ee427c603 100755 --- a/packages/api/src/util.ts +++ b/packages/api/src/util.ts @@ -279,7 +279,7 @@ export function getEnv(): BackendEnv { gcsUploadPrivateBucket: parse('GCS_UPLOAD_PRIVATE_BUCKET'), dailyUploadLimit: parse('GCS_UPLOAD_DAILY_LIMIT') ? parseInt(parse('GCS_UPLOAD_DAILY_LIMIT'), 10) - : 30, // default to 30 + : 5, // default to 5 } const sender = { message: parse('SENDER_MESSAGE'),