From cc2b492c162fca8e2d917238b6ecdc72e64cd7c8 Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Thu, 9 Jun 2022 12:38:09 +0800
Subject: [PATCH] Fix tests

---
 packages/api/test/resolvers/labels.test.ts | 43 +++++++++++++++-------
 1 file changed, 30 insertions(+), 13 deletions(-)

diff --git a/packages/api/test/resolvers/labels.test.ts b/packages/api/test/resolvers/labels.test.ts
index 7b469f80e..a014ac8a4 100644
--- a/packages/api/test/resolvers/labels.test.ts
+++ b/packages/api/test/resolvers/labels.test.ts
@@ -18,6 +18,7 @@ import {
   addHighlightToPage,
   getHighlightById,
 } from '../../src/elastic/highlights'
+import { refreshIndex } from '../../src/elastic'
 
 describe('Labels API', () => {
   const username = 'fakeUser'
@@ -219,34 +220,49 @@ describe('Labels API', () => {
     context('when label exists', () => {
       let toDeleteLabel: Label
 
-      before(async () => {
-        toDeleteLabel = await createTestLabel(user, 'label4', '#ffffff')
-        labelId = toDeleteLabel.id
-      })
+      context('when label is not used', () => {
+        before(async () => {
+          toDeleteLabel = await createTestLabel(
+            user,
+            'label not in use',
+            '#ffffff'
+          )
+          labelId = toDeleteLabel.id
+        })
 
-      it('should delete label', async () => {
-        await graphqlRequest(query, authToken).expect(200)
-        const label = await getRepository(Label).findOneBy({ id: labelId })
-        expect(label).to.not.exist
+        it('should delete label', async () => {
+          await graphqlRequest(query, authToken).expect(200)
+          const label = await getRepository(Label).findOneBy({ id: labelId })
+          expect(label).not.exist
+        })
       })
 
       context('when a page has this label', () => {
         before(async () => {
+          toDeleteLabel = await createTestLabel(user, 'page label', '#ffffff')
+          labelId = toDeleteLabel.id
           await addLabelInPage(page.id, toDeleteLabel, ctx)
         })
 
         it('should update page', async () => {
           await graphqlRequest(query, authToken).expect(200)
-          const updatedPage = await getPageById(page.id)
+          await refreshIndex()
 
-          expect(updatedPage?.labels).not.to.include(toDeleteLabel)
+          const updatedPage = await getPageById(page.id)
+          expect(updatedPage?.labels).not.deep.include(toDeleteLabel)
         })
       })
 
       context('when a highlight has this label', () => {
-        const highlightId = 'testDeleteLabel'
+        const highlightId = generateFakeUuid()
 
         before(async () => {
+          toDeleteLabel = await createTestLabel(
+            user,
+            'highlight label',
+            '#ffffff'
+          )
+          labelId = toDeleteLabel.id
           const highlight: Highlight = {
             id: highlightId,
             patch: 'test patch',
@@ -261,9 +277,10 @@ describe('Labels API', () => {
 
         it('should update highlight', async () => {
           await graphqlRequest(query, authToken).expect(200)
-          const updatedHighlight = await getHighlightById(highlightId)
+          await refreshIndex()
 
-          expect(updatedHighlight?.labels).not.to.include(toDeleteLabel)
+          const updatedHighlight = await getHighlightById(highlightId)
+          expect(updatedHighlight?.labels).not.deep.include(toDeleteLabel)
         })
       })
     })