From e93b3577dcd8209668d77a29048635d1b98c0ccd Mon Sep 17 00:00:00 2001 From: Jackson Harper Date: Mon, 2 Oct 2023 18:51:50 +0800 Subject: [PATCH] Fix the label remove click handler in the extension --- pkg/extension/src/scripts/content/toast.js | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/pkg/extension/src/scripts/content/toast.js b/pkg/extension/src/scripts/content/toast.js index 8c1d6f9fd..02d8d95e2 100644 --- a/pkg/extension/src/scripts/content/toast.js +++ b/pkg/extension/src/scripts/content/toast.js @@ -699,6 +699,7 @@ function addLabel(labelList, labelInput, labelValue) { // first check if the label is already entered: const existingLabel = labels.find((l) => l.name === labelValue) + const labelID = existingLabel ? existingLabel.id : getTempUUID() const labelEntryItem = labelList.querySelector('#label-entry-item') const inputItem = labelEntryItem.querySelector('#omnivore-edit-label-input') @@ -740,6 +741,14 @@ labelList.insertBefore(labelElem, labelEntryItem) labelInput.value = '' + const removeButton = labelElem.querySelector('.label-remove-button') + if (removeButton) { + removeButton.onclick = (event) => { + removeLabel(labelList, labelID) + event.preventDefault() + } + } + const form = labelList.closest('#omnivore-edit-labels-form') if (existingLabel) { const element = form.querySelector( @@ -752,7 +761,7 @@ // insert a toggle row at the top const rowList = form.querySelector('#omnivore-edit-labels-list') const newLabel = { - id: getTempUUID(), + id: labelID, color: labelColor, name: labelValue, temporary: true,