From e0b9a6689a09acebb58d98197357123634512f0f Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Fri, 30 Dec 2022 11:22:41 +0800
Subject: [PATCH] Not raise error when there is conflict of setting labels in
 highlights

---
 packages/api/src/elastic/labels.ts | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/packages/api/src/elastic/labels.ts b/packages/api/src/elastic/labels.ts
index 1551373d8..11119d99b 100644
--- a/packages/api/src/elastic/labels.ts
+++ b/packages/api/src/elastic/labels.ts
@@ -296,16 +296,14 @@ export const setLabelsForHighlight = async (
       conflicts: 'proceed', // ignore conflicts
     })
 
-    if (!body.updated) {
-      return false
-    }
-
-    for (const label of labels) {
-      await ctx.pubsub.entityCreated<Label & { highlightId: string }>(
-        EntityType.LABEL,
-        { highlightId, ...label },
-        ctx.uid
-      )
+    if (body.updated > 0) {
+      for (const label of labels) {
+        await ctx.pubsub.entityCreated<Label & { highlightId: string }>(
+          EntityType.LABEL,
+          { highlightId, ...label },
+          ctx.uid
+        )
+      }
     }
 
     return true