Benature/omnivore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Start passing in position info when creating highlights on PDFs

Browse Source
This commit is contained in:
Jackson Harper
2023-02-02 15:19:58 +08:00
parent 08405dbcc2
commit d8aa36f148
2 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
apple/OmnivoreKit/Sources/App/PDFSupport/PDFViewer.swift
View File

@ -296,7 +296,10 @@ import Utils
shortId: shortId,
highlightID: highlightID,
quote: quote,
patch: patch
patch: patch,
// TODO
positionPercent: nil,
positionAnchorIndex: Int(pageView.pageIndex)
)
} else {
let overlappingRects = overlapping.map(\.rects).compactMap { $0 }.flatMap { $0 }
@ -317,6 +320,9 @@ import Utils
highlightID: highlightID,
quote: quote,
patch: patch,
// TODO:
positionPercent: nil,
positionAnchorIndex: Int(pageView.pageIndex),
overlapHighlightIdList: highlightIds(overlapping)
)
}

16
apple/OmnivoreKit/Sources/App/PDFSupport/PDFViewerViewModel.swift
View File

@ -22,7 +22,9 @@ final class PDFViewerViewModel: ObservableObject {
shortId: String,
highlightID: String,
quote: String,
patch: String
patch: String,
positionPercent: Double?,
positionAnchorIndex: Int?
) {
_ = dataService.createHighlight(
shortId: shortId,
@ -30,9 +32,8 @@ final class PDFViewerViewModel: ObservableObject {
quote: quote,
patch: patch,
articleId: pdfItem.itemID,
// TODO:
positionPercent: nil,
positionAnchorIndex: nil
positionPercent: positionPercent,
positionAnchorIndex: positionAnchorIndex
)
}
@ -43,6 +44,8 @@ final class PDFViewerViewModel: ObservableObject {
highlightID: String,
quote: String,
patch: String,
positionPercent: Double?,
positionAnchorIndex: Int?,
overlapHighlightIdList: [String]
) {
_ = dataService.mergeHighlights(
@ -51,9 +54,8 @@ final class PDFViewerViewModel: ObservableObject {
quote: quote,
patch: patch,
articleId: pdfItem.itemID,
// TODO:
positionPercent: nil,
positionAnchorIndex: nil,
positionPercent: positionPercent,
positionAnchorIndex: positionAnchorIndex,
overlapHighlightIdList: overlapHighlightIdList
)
}