c3084d668e
Why didnt i use const here?
2022-12-30 11:22:49 +08:00
194d93912c
Use let instead of var
2022-12-30 11:21:41 +08:00
dba672a9d5
Set labels on toggle
2022-12-30 11:20:05 +08:00
3040a35203
Reset modal on close
2022-12-29 17:45:29 +08:00
e03da2475d
Update setlabels to save on close, always use the modal
2022-12-29 17:37:52 +08:00
2c6b6ef3cc
Set labels before making API call
2022-12-29 16:42:22 +08:00
49bca60e2b
More debugging
2022-12-29 15:55:54 +08:00
f060a0d4df
Add some debugging for set labels on highlights
2022-12-29 15:37:50 +08:00
cbfecca505
Sort labels alphabetically on the labels popup
2022-12-22 10:14:40 +08:00
79ae04215e
Remove unused imports
2022-12-21 13:14:49 +08:00
f8b828a070
Disable empty arrow, this func isnt needed as we call save
2022-12-21 12:59:12 +08:00
f13fc9c35a
Only save labels from the modal when the user finishes selection
...
This prevents creating issues by calling the setlabels mutation
too frequently if a user is rapidly changing labels, if that
happens a failure in the API could cause the user's changes
to be overwritten.
2022-12-21 12:29:34 +08:00
63b01ca2e6
Revert android touch position changes
2022-12-20 11:33:01 +08:00
6a94fb4aa7
Fix props
2022-12-19 21:27:10 +08:00
1ac5beef6c
Clean up recommendation quotes view
2022-12-19 17:14:21 +08:00
e8cd9f4412
Shared highlights UX
2022-12-19 17:07:27 +08:00
447458f6be
adjust tap location with scroll offset
2022-12-19 17:07:27 +08:00
55e925cc98
Clean up iOS recommendations, show a primer on first load
2022-12-19 17:07:27 +08:00
77c0f7f6be
Set the initial height for the labels view so it doesn't resize after load
2022-12-18 19:00:30 +08:00
bc1ddd5681
adjust menu location with toolbar height. user screenx/y to store tap location
2022-12-07 15:21:19 -08:00
4a97c4f93a
Merge pull request #1480 from omnivore-app/fix/android-webview-highlight-taps
...
Webview Highlight Taps - Android
2022-12-05 20:16:43 -08:00
009cd59628
Allow setting labels on highlights via the highlight dropdown
2022-12-02 16:16:48 +08:00
16654bafef
Refactor the SetLabels components to allow them to take a highlight or article
2022-12-02 15:30:27 +08:00
e4c89c0256
Set zIndex on modals so they display above the top toolbar on smaller screens
2022-12-02 10:29:13 +08:00
a5b9fd6089
New kbar and keyboard command for opening the notebook
2022-12-02 10:01:01 +08:00
c022ef1874
implement copy highlight action
2022-12-01 11:15:17 -08:00
59da048849
adjust tap location with scroll offset
2022-12-01 10:27:27 -08:00
46ba2f1710
sync highlight deletion from android
2022-12-01 10:27:16 -08:00
4e8c316fea
use screenX/Y to store tap coordinate
2022-12-01 10:27:04 -08:00
5f2a667bec
track last tap location to show android highlight menu in right place
2022-12-01 10:26:50 -08:00
f13c3551fa
send highlightID in json payload send to native app
2022-12-01 10:25:19 -08:00
f2d8d48e41
Tweak the highlights view padding, handle empty string annotations
2022-12-01 18:57:59 +08:00
a4a32dec2b
Make the web notebook UI better match the iOS UI
2022-12-01 18:26:35 +08:00
16f17cae3b
Merge pull request #1475 from omnivore-app/feat/highlight-labels
...
Allow setting labels from the highlights list view on iOS
2022-12-01 15:34:20 +08:00
1b57d879ed
Better handling of errors in javascript while waiting in swift
...
Two main changes here:
- Wait for JS highlight methods to complete, if an error occurs
post that error back to Swift.
- When creating a highlight with a note, post a message back to
Swift to signify success. We wait for that message instead of
closing immediately, so that a user doesn't lose their note if
creating the highlight failed.
2022-11-30 21:09:02 +08:00
b4901b14d7
Remove unused event stuff
2022-11-30 10:23:12 +08:00
521ecff381
Update the highlightsRef list when creating a merged PDF highlight
2022-11-30 10:07:50 +08:00
ce8c023733
Use the highlightsRef when opening the all highlights modal
2022-11-30 10:03:16 +08:00
885e80fb46
Allow creating notes on PDF highlights
2022-11-29 21:37:57 +08:00
53c9881fe0
Allow setting highlight labels by clicking a highlight
2022-11-29 11:58:32 +08:00
aa856a5366
If in a pre block dont replace whitespace when highlighting
2022-11-15 15:34:27 +08:00
472e11e9db
Add three new fonts, display fonts in the font selector
2022-11-02 18:04:55 +08:00
531275a013
Remove some more temp theme stuff, update reader bundle
2022-11-01 18:27:05 +08:00
467a37e8cc
WIP: New themes and reader preferences for iOS
2022-11-01 17:40:11 +08:00
f0037a758b
Article-Title Fix
2022-10-14 08:43:47 -05:00
25055598e3
Update read position while listening to audio
2022-10-11 17:22:40 +08:00
b3733a4ee6
Better naming, fix issue with highlight bar placement
2022-10-07 18:08:32 +08:00
846a720582
Use near cursor display on the highlight bar on non-touch devices
2022-10-07 16:58:33 +08:00
2be59bdf89
stub logs in for web action handler in web reader view Model
2022-09-26 19:20:01 -07:00
67cf702ada
update android js interface. send actionID and json to WebReaderViewModel
2022-09-26 19:19:29 -07:00
