Merge pull request #823 from omnivore-app/fix/delete-label

Fix a script error by deleting both labels in pages and highlights
2022-06-21 09:31:27 +08:00
parent bbae99dd7e 9a2f4b300a
commit 35bb9abdd4
1 changed files with 1 additions and 1 deletions
--- a/packages/api/src/elastic/labels.ts
+++ b/packages/api/src/elastic/labels.ts
@ -104,7 +104,7 @@ export const deleteLabel = async (
      index: INDEX_ALIAS,
      body: {
        script: {
-          source: `if (ctx._source.highlights != null) {
+          source: `if (ctx._source.highlights != null && ctx._source.highlights[0].labels != null) {
                     ctx._source.highlights[0].labels.removeIf(label -> label.name == params.label)
                   }
                   if (ctx._source.labels != null) {