make internal optional in label response

packages/api/src/generated/graphql.ts

@@ -1022,7 +1022,7 @@ export type Label = {
   createdAt?: Maybe<Scalars['Date']>;
   description?: Maybe<Scalars['String']>;
   id: Scalars['ID'];
-  internal: Scalars['Boolean'];
+  internal?: Maybe<Scalars['Boolean']>;
   name: Scalars['String'];
   position?: Maybe<Scalars['Int']>;
 };
@@ -4907,7 +4907,7 @@ export type LabelResolvers<ContextType = ResolverContext, ParentType extends Res
   createdAt?: Resolver<Maybe<ResolversTypes['Date']>, ParentType, ContextType>;
   description?: Resolver<Maybe<ResolversTypes['String']>, ParentType, ContextType>;
   id?: Resolver<ResolversTypes['ID'], ParentType, ContextType>;
-  internal?: Resolver<ResolversTypes['Boolean'], ParentType, ContextType>;
+  internal?: Resolver<Maybe<ResolversTypes['Boolean']>, ParentType, ContextType>;
   name?: Resolver<ResolversTypes['String'], ParentType, ContextType>;
   position?: Resolver<Maybe<ResolversTypes['Int']>, ParentType, ContextType>;
   __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;

packages/api/src/generated/schema.graphql

@@ -909,7 +909,7 @@ type Label {
   createdAt: Date
   description: String
   id: ID!
-  internal: Boolean!
+  internal: Boolean
   name: String!
   position: Int
 }

packages/api/src/resolvers/article/index.ts

@@ -1160,8 +1160,12 @@ export const bulkActionResolver = authorized<
   }
 )
 
-export const setFavoriteArticleResolver = authorized<
+export type SetFavoriteArticleSuccessPartial = Merge<
   SetFavoriteArticleSuccess,
+  { favoriteArticle: PartialArticle }
+>
+export const setFavoriteArticleResolver = authorized<
+  SetFavoriteArticleSuccessPartial,
   SetFavoriteArticleError,
   MutationSetFavoriteArticleArgs
 >(async (_, { id }, { claims: { uid }, log, pubsub }) => {
@@ -1200,7 +1204,10 @@ export const setFavoriteArticleResolver = authorized<
     log.debug('Favorites label added:', result)
 
     return {
-      favoriteArticle: page,
+      favoriteArticle: {
+        ...page,
+        isArchived: !!page.archivedAt,
+      },
     }
   } catch (error) {
     log.debug('Error adding Favorites label:', error)

packages/api/src/resolvers/function_resolvers.ts

@@ -23,7 +23,6 @@ import {
   generateDownloadSignedUrl,
   generateUploadFilePathName,
 } from '../utils/uploads'
-import { setFavoriteArticleResolver } from './article'
 import { optInFeatureResolver } from './features'
 import { uploadImportFileResolver } from './importers/uploadImportFileResolver'
 import {
@@ -88,6 +87,7 @@ import {
   sendInstallInstructionsResolver,
   setBookmarkArticleResolver,
   setDeviceTokenResolver,
+  setFavoriteArticleResolver,
   setFollowResolver,
   setIntegrationResolver,
   setLabelsForHighlightResolver,

packages/api/src/schema.ts

@@ -1418,7 +1418,7 @@ const schema = gql`
     description: String
     createdAt: Date
     position: Int
-    internal: Boolean!
+    internal: Boolean
   }
 
   type LabelsSuccess {