Benature/omnivore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #490 from omnivore-app/fix/srcset-density

Browse Source 
Handle srcset image density specifications
This commit is contained in:
Jackson Harper
2022-04-26 15:57:55 -07:00
committed by GitHub
parent 1f963d64cc d2bb359f5c
commit 6d87d048a9
2 changed files with 22 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/readabilityjs/Readability.js
View File

@ -562,7 +562,7 @@ Readability.prototype = {
if (d) {
const proxySrc = this.createImageProxyUrl(this.toAbsoluteURI(link));
resultSrcset += `${proxySrc} ${d},`;
resultSrcset += `${proxySrc} ${d}x,`;
}
}

21
packages/readabilityjs/test/test-readability.js
View File

@ -281,6 +281,27 @@ describe("Readability API", function() {
var content = new Readability(dom.window.document).parse().content;
expect(content).eql(expected_xhtml);
});
it("should handle srcset elements with density descriptors", function() {
var dom = new JSDOM('My image: <img src="https://webkit.org/demos/srcset/image-src.png" ' +
'srcset="https://webkit.org/demos/srcset/image-1x.png 1x, ' +
'https://webkit.org/demos/srcset/image-2x.png 2x, ' +
'https://webkit.org/demos/srcset/image-3x.png 3x, ' +
'https://webkit.org/demos/srcset/image-4x.png 4x">'
);
var expected_xhtml = '<div id="readability-page-1" class="page">My image: ' +
'<img src="https://webkit.org/demos/srcset/image-src.png" ' +
'srcset="https://webkit.org/demos/srcset/image-1x.png 1x,' +
'https://webkit.org/demos/srcset/image-2x.png 2x,' +
'https://webkit.org/demos/srcset/image-3x.png 3x,' +
'https://webkit.org/demos/srcset/image-4x.png 4x,"></div>';
var content = new Readability(dom.window.document, {
createImageProxyUrl: function(url) {
return url;
}
}).parse().content;
expect(content).eql(expected_xhtml);
});
});
});