Benature/omnivore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

use oslog rather than print statements in models package

Browse Source
This commit is contained in:
Satindar Dhillon
2022-04-21 14:44:08 -07:00
parent 57be731aa9
commit 76e35cef0a
6 changed files with 20 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
apple/OmnivoreKit/Sources/Models/CoreData/StorageProvider.swift
View File

@ -1,5 +1,8 @@
import CoreData
import Foundation
import OSLog
let logger = Logger(subsystem: "app.omnivore", category: "models")
/// An `NSPersistentContainer` subclass that lives in the `Models` package so that
/// the data model is looked for in the same package bundle (rather than the main bundle)

12
apple/OmnivoreKit/Sources/Models/DataModels/FeedItem.swift
View File

@ -197,11 +197,11 @@ public extension Sequence where Element == FeedItemDep {
do {
try context.save()
print("LinkedItems saved succesfully")
logger.debug("LinkedItems saved succesfully")
return linkedItems
} catch {
context.rollback()
print("Failed to save LinkedItems: \(error.localizedDescription)")
logger.debug("Failed to save LinkedItems: \(error.localizedDescription)")
return nil
}
}
@ -239,10 +239,10 @@ public extension LinkedItem {
do {
try context.save()
print("LinkedItem updated succesfully")
logger.debug("LinkedItem updated succesfully")
} catch {
context.rollback()
print("Failed to update LinkedItem: \(error.localizedDescription)")
logger.debug("Failed to update LinkedItem: \(error.localizedDescription)")
}
}
@ -251,10 +251,10 @@ public extension LinkedItem {
do {
try context.save()
print("LinkedItem removed")
logger.debug("LinkedItem removed")
} catch {
context.rollback()
print("Failed to remove LinkedItem: \(error.localizedDescription)")
logger.debug("Failed to remove LinkedItem: \(error.localizedDescription)")
}
}
}

4
apple/OmnivoreKit/Sources/Models/DataModels/HighlightDep.swift
View File

@ -59,11 +59,11 @@ public struct HighlightDep: Identifiable, Hashable, Codable {
do {
try context.save()
print("Highlight saved succesfully")
logger.debug("Highlight saved succesfully")
return highlight
} catch {
context.rollback()
print("Failed to save Highlight: \(error.localizedDescription)")
logger.debug("Failed to save Highlight: \(error.localizedDescription)")
return nil
}
}

5
apple/OmnivoreKit/Sources/Services/DataService/DataService.swift
View File

@ -4,13 +4,14 @@ import Foundation
import Models
import OSLog
let logger = Logger(subsystem: "app.omnivore", category: "data-service")
public final class DataService: ObservableObject {
public static var registerIntercomUser: ((String) -> Void)?
public static var showIntercomMessenger: (() -> Void)?
public let appEnvironment: AppEnvironment
let networker: Networker
static let logger = Logger(subsystem: "app.omnivore", category: "data-service")
let persistentContainer: PersistentContainer
var subscriptions = Set<AnyCancellable>()
@ -48,7 +49,7 @@ public final class DataService: ObservableObject {
do {
try persistentContainer.viewContext.save()
} catch {
DataService.logger.debug("failed to delete objects")
logger.debug("failed to delete objects")
}
}

4
apple/OmnivoreKit/Sources/Services/DataService/Queries/ViewerFetcher.swift
View File

@ -64,11 +64,11 @@ private struct ViewerInternal {
do {
try context.save()
DataService.logger.debug("Viewer saved succesfully")
logger.debug("Viewer saved succesfully")
return viewer
} catch {
context.rollback()
DataService.logger.debug("Failed to save Viewer: \(error.localizedDescription)")
logger.debug("Failed to save Viewer: \(error.localizedDescription)")
return nil
}
}

8
apple/OmnivoreKit/Sources/Services/InternalModels/InternalNewsletterEmail.swift
View File

@ -12,11 +12,11 @@ struct InternalNewsletterEmail {
do {
try context.save()
DataService.logger.debug("NewsletterEmail saved succesfully")
logger.debug("NewsletterEmail saved succesfully")
return newsletterEmail
} catch {
context.rollback()
DataService.logger.debug("Failed to save NewsletterEmail: \(error.localizedDescription)")
logger.debug("Failed to save NewsletterEmail: \(error.localizedDescription)")
return nil
}
}
@ -36,11 +36,11 @@ extension Sequence where Element == InternalNewsletterEmail {
do {
try context.save()
DataService.logger.debug("NewsletterEmail saved succesfully")
logger.debug("NewsletterEmail saved succesfully")
return newsletterEmails
} catch {
context.rollback()
DataService.logger.debug("Failed to save NewsletterEmail: \(error.localizedDescription)")
logger.debug("Failed to save NewsletterEmail: \(error.localizedDescription)")
return nil
}
}