Benature/omnivore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #4015 from omnivore-app/content-fetch-event

Browse Source 
fix: only send content_fetch_failure event to analytics
This commit is contained in:
Hongbo Wu
2024-05-31 12:58:13 +08:00
committed by GitHub
parent a802bab1c3 e932777347
commit 9494ef8bcd
2 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/api/src/jobs/update_home.ts
View File

@ -202,11 +202,9 @@ const rankCandidates = async (
return candidates
}
const unscoredCandidates = candidates.filter((item) => item.score === 0)
const data = {
user_id: userId,
items: unscoredCandidates.reduce((acc, item) => {
items: candidates.reduce((acc, item) => {
acc[item.id] = {
library_item_id: item.id,
title: item.title,
@ -227,14 +225,14 @@ const rankCandidates = async (
}, {} as Record<string, Feature>),
}
const newScores = await getScores(data)
const scores = await getScores(data)
// update scores for candidates
unscoredCandidates.forEach((item) => {
item.score = newScores[item.id]['score'] || 0
candidates.forEach((item) => {
item.score = scores[item.id]['score'] || 0
})
// rank candidates by score in ascending order
candidates.sort((a, b) => a.score - b.score)
// rank candidates by score in descending order
candidates.sort((a, b) => b.score - a.score)
return candidates
}

2
packages/content-fetch/src/analytics.ts
View File

@ -17,7 +17,7 @@ class PostHogClient implements AnalyticClient {
}
capture(userIds: string[], { properties, result }: AnalyticEvent) {
if (process.env.SEND_ANALYTICS) {
if (process.env.SEND_ANALYTICS && result === 'failure') {
userIds.forEach((userId) => {
this.client.capture({
distinctId: userId,