add testcases

packages/thumbnail-handler/package.json

@@ -17,7 +17,8 @@
   "devDependencies": {
     "chai": "^4.3.6",
     "eslint-plugin-prettier": "^4.0.0",
-    "mocha": "^10.0.0"
+    "mocha": "^10.0.0",
+    "nock": "^13.3.1"
   },
   "dependencies": {
     "@google-cloud/functions-framework": "3.1.2",

packages/thumbnail-handler/src/index.ts

@@ -158,8 +158,10 @@ const getImageSize = async (url: string): Promise<[number, number] | null> => {
   }
 }
 
-// credit to https://github.com/reddit-archive/reddit/blob/753b17407e9a9dca09558526805922de24133d53/r2/r2/lib/media.py#L706
-const findThumbnail = async (content: string): Promise<string | null> => {
+// credit: https://github.com/reddit-archive/reddit/blob/753b17407e9a9dca09558526805922de24133d53/r2/r2/lib/media.py#L706
+export const findThumbnail = async (
+  content: string
+): Promise<string | null> => {
   const dom = parseHTML(content).document
 
   // find the largest and squarest image as the thumbnail

packages/thumbnail-handler/test/fixtures/findThumbnail.html

@@ -0,0 +1,9 @@
+<DIV class="page" id="readability-page-1">
+    <img src="https://omnivore.app/small.png" alt="small image" />
+
+    <img src="https://omnivore.app/large_and_square.png" alt="large and square image" />
+
+    <img src="https://omnivore.app/wide.png" alt="wide image" />
+
+    <img src="https://omnivore.app/sprite.png" alt="sprite image" />
+</DIV>

packages/thumbnail-handler/test/index.test.ts

@@ -0,0 +1,30 @@
+import { expect } from 'chai'
+import fs from 'fs'
+import 'mocha'
+import nock from 'nock'
+import path from 'path'
+import { findThumbnail } from '../src'
+
+describe('findThumbnail', () => {
+  it('finds the largest and squarest image', async () => {
+    const images = ['large_and_square', 'small', 'sprite', 'wide']
+    // mock getting image by url
+    images.forEach((image) => {
+      nock('https://omnivore.app')
+        .get(`/${image}.png`)
+        .replyWithFile(200, path.join(__dirname, 'fixtures', `${image}.png`))
+    })
+    // get html content from file
+    const content = fs.readFileSync(
+      path.join(__dirname, 'fixtures', 'findThumbnail.html'),
+      'utf8'
+    )
+    // find thumbnail
+    const thumbnail = await findThumbnail(content)
+
+    expect(thumbnail).to.eql('https://omnivore.app/large_and_square.png')
+
+    // clean up
+    nock.cleanAll()
+  })
+})

packages/thumbnail-handler/test/stub.test.ts

@@ -1,8 +0,0 @@
-import 'mocha'
-import { expect } from 'chai'
-
-describe('stub test', () => {
-  it('should pass', () => {
-    expect(true).to.be.true
-  })
-})