Benature/omnivore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #212 from omnivore-app/fix/article-positioning

Browse Source 
Fix issues with read position based on following two events
This commit is contained in:
Jackson Harper
2022-03-09 20:55:11 -08:00
committed by GitHub
parent c1e9bbe690 f29d0fdb71
commit d41ea276d6
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/web/components/templates/article/Article.tsx
View File

@ -28,9 +28,7 @@ export type ArticleProps = {
export function Article(props: ArticleProps): JSX.Element {
const highlightTheme = isDarkTheme() ? 'dark' : 'default'
const [readingProgress, setReadingProgress] = useState(
props.initialReadingProgress || 0
)
const [readingProgress, setReadingProgress] = useState(props.initialReadingProgress)
const [readingAnchorIndex, setReadingAnchorIndex] = useState(
props.initialAnchorIndex
@ -43,21 +41,24 @@ export function Article(props: ArticleProps): JSX.Element {
useReadingProgressAnchor(articleContentRef, setReadingAnchorIndex)
const debouncedReadingProgress = useDebounce(readingProgress, 1000)
const debouncedReadingAnchorIndex = useDebounce(readingAnchorIndex, 1000)
const debouncedReadingProgress = useDebounce(readingProgress, 1000);
useEffect(() => {
;(async () => {
if (!debouncedReadingProgress) return
await articleReadingProgressMutation({
id: props.articleId,
readingProgressPercent: debouncedReadingProgress,
readingProgressAnchorIndex: readingAnchorIndex,
})
})()
// We don't react to changes to readingAnchorIndex we
// only care about the progress (scroll position) changed.
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [
props.articleId,
debouncedReadingProgress,
debouncedReadingAnchorIndex,
readingAnchorIndex,
])