Benature/omnivore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #3924 from omnivore-app/feature/digest-analytics-backend

Browse Source 
send analytic events for each digest channel
This commit is contained in:
Hongbo Wu
2024-05-09 14:57:04 +08:00
committed by GitHub
parent 534b7b624d 17708915d9
commit dc75dc28e5
3 changed files with 34 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
packages/api/src/jobs/ai/create_digest.ts
View File

@ -28,6 +28,7 @@ import {
findUserAndPersonalization,
sendPushNotifications,
} from '../../services/user'
import { analytics } from '../../utils/analytics'
import { enqueueSendEmail } from '../../utils/createTask'
import { wordsCount } from '../../utils/helpers'
import { logger } from '../../utils/logger'
@ -674,19 +675,23 @@ export const moveDigestToLibrary = async (user: User, digest: Digest) => {
const chapters = digest.chapters ?? []
const html = `
<div style="text-align: justify;" class="_omnivore_digest">
${chapters
.map(
(chapter) => `
<div>
<a href="${chapter.url}"><h3>${chapter.title} (${chapter.wordCount} words)</h3></a>
<div>
${chapter.summary}
</div>
</div>`
)
.join('')}
</div>`
<html>
<body>
<div style="text-align: justify;" class="_omnivore_digest">
${chapters
.map(
(chapter) => `
<div>
<a href="${chapter.url}"><h3>${chapter.title} (${chapter.wordCount} words)</h3></a>
<div>
${chapter.summary}
</div>
</div>`
)
.join('')}
</div>
</body>
</html>`
const previewImage = await findThumbnail(chapters)
@ -716,15 +721,27 @@ const sendToChannels = async (
deduplicateChannels.map(async (channel) => {
switch (channel) {
case 'push':
return sendPushNotification(user.id, digest)
await sendPushNotification(user.id, digest)
break
case 'email':
return sendEmail(user, digest, deduplicateChannels)
await sendEmail(user, digest, deduplicateChannels)
break
case 'library':
return moveDigestToLibrary(user, digest)
await moveDigestToLibrary(user, digest)
break
default:
logger.error('Unknown channel', { channel })
return
}
analytics.capture({
distinctId: user.id,
event: 'digest_created',
properties: {
channel,
digestId: digest.id,
},
})
})
)
}

1
packages/api/src/utils/analytics.ts
View File

@ -30,6 +30,7 @@ class PostHogClient implements AnalyticClient {
properties: {
...properties,
client,
env: env.server.apiEnv,
},
})
}

1
packages/api/src/utils/usernamePolicy.ts
View File

@ -172,7 +172,6 @@ const RESERVED_NAMES = new Set([
'xmpp',
'yaml',
'yml',
'digest',
])
export const validateUsername = (username: string): boolean => {