set position to fixed for article container wrapper in /app routes

This commit is contained in:
Satindar Dhillon
2022-03-08 15:20:25 -08:00
parent 191fcb2675
commit ddb13770d3
3 changed files with 16 additions and 7 deletions

View File

@ -1,6 +1,12 @@
import { PageMetaData, PageMetaDataProps } from '../patterns/PageMetaData'
import { Box } from '../elements/LayoutPrimitives'
import { ReactNode, MutableRefObject, useEffect, useContext, useState } from 'react'
import {
ReactNode,
MutableRefObject,
useEffect,
useContext,
useState,
} from 'react'
import { PrimaryHeader } from './../patterns/PrimaryHeader'
import { useGetViewerQuery } from '../../lib/networking/queries/useGetViewerQuery'
import { navigationCommands } from '../../lib/keyboardShortcuts/navigationShortcuts'
@ -11,7 +17,6 @@ import { ConfirmationModal } from '../patterns/ConfirmationModal'
import { KeyboardShortcutListModal } from './KeyboardShortcutListModal'
import { logoutMutation } from '../../lib/networking/mutations/logoutMutation'
type PrimaryLayoutProps = {
children: ReactNode
pageTestId: string
@ -25,7 +30,8 @@ export function PrimaryLayout(props: PrimaryLayoutProps): JSX.Element {
const { viewerData } = useGetViewerQuery()
const router = useRouter()
const [showLogoutConfirmation, setShowLogoutConfirmation] = useState(false)
const [showKeyboardCommandsModal, setShowKeyboardCommandsModal] = useState(false)
const [showKeyboardCommandsModal, setShowKeyboardCommandsModal] =
useState(false)
useKeyboardShortcuts(navigationCommands(router))

View File

@ -63,10 +63,12 @@ export function Article(props: ArticleProps): JSX.Element {
// Post message to webkit so apple app embeds get progress updates
useEffect(() => {
window?.webkit?.messageHandlers.readingProgressUpdate?.postMessage({
progress: debouncedReadingProgress,
})
}, [debouncedReadingProgress])
if (typeof window?.webkit != 'undefined') {
window.webkit.messageHandlers.readingProgressUpdate?.postMessage({
progress: debouncedReadingProgress,
})
}
}, [readingProgress, debouncedReadingProgress])
const setScrollWatchedElement = useScrollWatcher(
(changeset: ScrollOffsetChangeset) => {

View File

@ -69,6 +69,7 @@ function AppArticleEmbedContent(
<Box
ref={scrollRef}
css={{
position: 'fixed',
overflowY: 'auto',
height: '100%',
width: '100vw',