Benature/omnivore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1467 from omnivore-app/fix/hide-url-check

Browse Source 
Handle invalid URLs in the shouldHideUrl check
This commit is contained in:
Jackson Harper
2022-11-25 16:31:11 +08:00
committed by GitHub
parent 42a4f22c4b 9fde7c98a4
commit e0bbc8b7f3
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/web/components/patterns/LibraryCards/LinkedItemCard.tsx
View File

@ -5,10 +5,14 @@ import { HighlightItemCard } from './HighlightItemCard'
import { PageType } from '../../../lib/networking/fragments/articleFragment'
const shouldHideUrl = (url: string): boolean => {
const origin = new URL(url).origin
const hideHosts = ['https://storage.googleapis.com', 'https://omnivore.app']
if (hideHosts.indexOf(origin) != -1) {
return true
try {
const origin = new URL(url).origin
const hideHosts = ['https://storage.googleapis.com', 'https://omnivore.app']
if (hideHosts.indexOf(origin) != -1) {
return true
}
} catch {
console.log('invalid url item', url)
}
return false
}