Commit Graph

3943 Commits

Author SHA1 Message Date
1e4b499c40 Merge pull request #1327 from omnivore-app/fix/empty-tweet-links
Better handle <a> elements with no parent when looking for tweet placeholders
2022-10-18 13:05:18 +08:00
59427fa896 Mock the substack domain also when testing redirects
We were making the actual call to the redirected URL here,
instead of mocking it. We need to mock both the embedded email
domain, and the domain we are redirected to.
2022-10-18 12:51:53 +08:00
57676d381c Better handle <a elements with no parent when looking for tweet placeholders 2022-10-18 12:13:54 +08:00
8a3b340757 Merge pull request #1313 from omnivore-app/fix/mac-read-later
Mac App Read Now Fix
2022-10-17 13:10:24 -07:00
7a5ef4e174 Merge pull request #1319 from omnivore-app/fix/popular-read-signup
Dont crash if a popular read is not available on signup
2022-10-17 20:57:26 +08:00
5312c31ea7 Dont crash if a popular read is not available on signup 2022-10-17 20:45:04 +08:00
d7023beef0 Merge pull request #1317 from omnivore-app/fix/newsletter-fs-blog
Save fs.blog newsletter correctly
2022-10-17 18:50:55 +08:00
791bec17d1 Merge pull request #1316 from omnivore-app/fix/updated-getting-started-guide
Update the Getting started guide for new users
2022-10-17 18:31:06 +08:00
37439c6622 Save fs.blog newsletter correctly 2022-10-17 17:59:27 +08:00
08a1d4af91 Update the Getting started guide for new users 2022-10-17 17:11:25 +08:00
53c40c1550 use nsworkspace to deep link to mac app 2022-10-15 19:51:57 -07:00
9cc180d43b Merge pull request #1312 from omnivore-app/fix/support-page-loading
Support Page Intercom Loading
2022-10-14 16:42:49 -07:00
6a063acb23 add button to open chat in case it fails to load initially 2022-10-14 15:01:02 -07:00
b42ef5a5bc only call Intercom after load event is dispatched 2022-10-14 14:50:00 -07:00
fcef8e14e7 make sure analytics is setup before calling show on Intercom 2022-10-14 13:44:04 -07:00
04c94db52e Merge pull request #1311 from omnivore-app/bug/title-wrap
Article-Title Fix
2022-10-14 09:54:59 -05:00
f0037a758b Article-Title Fix 2022-10-14 08:43:47 -05:00
8ea727460c Merge pull request #1310 from omnivore-app/fix/update-since-api
Return deleted article in the updatesSince API response
2022-10-14 16:31:00 +08:00
496b28c9ee Return deleted article in the updatesSince API response 2022-10-14 13:50:53 +08:00
ef745cce3b Merge pull request #1308 from omnivore-app/fix/github-handler
Create a content handler for GitHub pages
2022-10-14 11:59:10 +08:00
22a5850c1e Merge pull request #1306 from omnivore-app/fix/audio-player-crash
Dont instantiate TabView with zero items
2022-10-13 12:08:36 -07:00
ff21770a70 Add GitHubHandler class 2022-10-13 18:38:01 +08:00
f39c6923b0 Create a content handler for GitHub pages
This will search for the markdown <article> element and make it
the only page element so we add a repo's README.
2022-10-13 18:11:14 +08:00
369240dff4 Merge pull request #1307 from omnivore-app/fix/escaped-utterance-in-speech-file
Do not escape utterance in speech file and do it when streaming
2022-10-13 18:11:06 +08:00
d2c6412289 Do not escape utterance in speech file and do it when streaming 2022-10-13 16:40:46 +08:00
d9c91c3137 Reset tabIndex when state is reset to loading
We track the state of the current index in two places: the audio
controller, which updates as audio as played, the tabView has its
own binding of the current index, this is to allow scrolling.

When the audio item being played changes, we need to reset the
state of the tabIndex. We do this by watching for state loading
which occurs when new audio is loaded.
2022-10-13 15:37:37 +08:00
fe1f4ee51d Update the scrubber max value when items change 2022-10-13 15:20:28 +08:00
bafe1bd338 Ensure the audio index is updated when items are changed 2022-10-13 15:04:57 +08:00
2e9bda7835 Dont instantiate TabView with zero items
Seems this prevents the crash when the TabView tries to set
its index to 0/0.
2022-10-13 14:02:17 +08:00
14c87a1240 Merge pull request #1298 from omnivore-app/feature/add-popular-read-when-signup
feature/add popular read when signup
2022-10-13 13:13:13 +08:00
8c2089d1b2 Merge pull request #1305 from omnivore-app/chore/mac-app-resurrection
Mac App Updates
2022-10-12 21:00:12 -07:00
d345aee14b Merge pull request #1303 from omnivore-app/chore/mac-app-resurrection
Mac App Updates
2022-10-13 11:24:55 +08:00
15d66daaca Merge pull request #1304 from omnivore-app/fix/milkroad-newsletters
Fix not correctly identify milkroad newsletters due to the HTML format changes again by the author
2022-10-13 11:15:07 +08:00
5dcde8dac3 Fix not correctly identify milkroad newsletters due to the HTML format changes again by the author 2022-10-13 10:52:03 +08:00
cd1b62b85b add min size to macos email login view frame 2022-10-12 13:33:59 -07:00
b3310c61c7 update buttons on welcome screen to work for macos 2022-10-12 13:23:22 -07:00
903e58b3c5 add empty subscriptions list message 2022-10-12 13:16:33 -07:00
8fcbfbbd2e fixes after rebasing 2022-10-12 12:58:32 -07:00
d84f41767f create a mac specific nav card 2022-10-12 10:11:11 -07:00
c287eb4a59 add os conditionals so the mac app compiles 2022-10-12 10:11:09 -07:00
460a013554 Merge pull request #1297 from omnivore-app/feat/navbar-refactor
Refactor how we do search and navbar on the library
2022-10-12 10:05:53 -07:00
624b7b4624 Merge pull request #1294 from omnivore-app/feature/saved-search
Recent searches feature
2022-10-12 22:11:57 +08:00
19d0d314db Fix tests 2022-10-12 18:05:17 +08:00
2b4b528c64 Merge pull request #1301 from omnivore-app/fix/substack-anchor-headers
Improvements to substack article handling
2022-10-12 15:15:45 +08:00
7af068e8dc Header fix adds the headers back in for this test case 2022-10-12 14:51:59 +08:00
989f0e2e31 Add test from the new Omnivore Getting Started article 2022-10-12 14:34:36 +08:00
57575c75aa Remove the subscriber dialog that was part of the header before 2022-10-12 14:31:34 +08:00
7a48cccac9 Save client in request context 2022-10-12 14:30:39 +08:00
0116304284 Dont exclude substacks in article headers
Substack uses this class on header elements like <h1> to give
them anchors in the documents, but we mark content with `header`
in its class name as unlikely.
2022-10-12 14:27:31 +08:00
9496827c6b Add popular reads to new users based on client 2022-10-12 13:59:08 +08:00