Merge pull request #3273 from omnivore-app/remove-invalid-url

remove invalid-url error from subscribing feed
2023-12-22 09:52:15 +08:00
parent a0f9366edd c939735678
commit 0dc3d6198c
4 changed files with 0 additions and 13 deletions
--- a/packages/api/src/generated/graphql.ts
+++ b/packages/api/src/generated/graphql.ts
@ -2790,7 +2790,6 @@ export enum SubscribeErrorCode {
  AlreadySubscribed = 'ALREADY_SUBSCRIBED',
  BadRequest = 'BAD_REQUEST',
  ExceededMaxSubscriptions = 'EXCEEDED_MAX_SUBSCRIPTIONS',
-  InvalidUrl = 'INVALID_URL',
  NotFound = 'NOT_FOUND',
  Unauthorized = 'UNAUTHORIZED'
 }
--- a/packages/api/src/generated/schema.graphql
+++ b/packages/api/src/generated/schema.graphql
@ -2190,7 +2190,6 @@ enum SubscribeErrorCode {
  ALREADY_SUBSCRIBED
  BAD_REQUEST
  EXCEEDED_MAX_SUBSCRIPTIONS
-  INVALID_URL
  NOT_FOUND
  UNAUTHORIZED
 }
--- a/packages/api/src/resolvers/subscriptions/index.ts
+++ b/packages/api/src/resolvers/subscriptions/index.ts
@ -241,16 +241,6 @@ export const subscribeResolver = authorized<
      }
    }

-    if (feedUrl !== input.url) {
-      log.info('feed url is different from user provided url', {
-        feedUrl,
-        inputUrl: input.url,
-      })
-      return {
-        errorCodes: [SubscribeErrorCode.InvalidUrl],
-      }
-    }
-
    // create new rss subscription
    const MAX_RSS_SUBSCRIPTIONS = env.subscription.feed.max

--- a/packages/api/src/schema.ts
+++ b/packages/api/src/schema.ts
@ -1737,7 +1737,6 @@ const schema = gql`
    NOT_FOUND
    ALREADY_SUBSCRIBED
    EXCEEDED_MAX_SUBSCRIPTIONS
-    INVALID_URL
  }

  union AddPopularReadResult = AddPopularReadSuccess | AddPopularReadError