Merge pull request #433 from omnivore-app/fix/update-label

Fix return undefined as updateLabelResult
This commit is contained in:
Jackson Harper
2022-04-18 14:25:38 -07:00
committed by GitHub

View File

@ -288,9 +288,16 @@ export const updateLabelResolver = authorized<
}
}
log.info('Updating a label', {
labels: {
source: 'resolver',
resolver: 'updateLabelResolver',
},
})
const result = await AppDataSource.transaction(async (t) => {
await setClaims(t, uid)
return await t.getRepository(Label).update(
return t.getRepository(Label).update(
{ id: labelId },
{
name: name,
@ -300,23 +307,13 @@ export const updateLabelResolver = authorized<
)
})
log.info('Updating a label', {
result,
labels: {
source: 'resolver',
resolver: 'updateLabelResolver',
},
})
if (!result) {
log.info('failed to update')
if (!result.affected) {
log.error('failed to update')
return {
errorCodes: [UpdateLabelErrorCode.BadRequest],
errorCodes: [UpdateLabelErrorCode.NotFound],
}
}
log.info('updated successfully')
return { label: label }
} catch (error) {
log.error('error updating label', error)