throw error if save-page job failed

packages/api/src/jobs/save_page.ts

@@ -360,7 +360,7 @@ export const savePageJob = async (data: Data, attemptsMade: number) => {
     )
 
     if (result.__typename == 'SaveError') {
-      throw new Error(result.message || 'Failed to save page')
+      throw new Error(result.message || result.errorCodes[0])
     }
 
     isImported = true

packages/api/src/services/save_page.ts

@@ -112,6 +112,7 @@ export const savePage = async (
       })
     } catch (e) {
       return {
+        __typename: 'SaveError',
         errorCodes: [SaveErrorCode.Unknown],
         message: 'Failed to create page save request',
       }
@@ -183,11 +184,14 @@ export const savePage = async (
       libraryItem: { id: clientRequestId },
     }
 
-    if (!(await createHighlight(highlight, clientRequestId, user.id))) {
-      return {
-        errorCodes: [SaveErrorCode.EmbeddedHighlightFailed],
-        message: 'Failed to save highlight',
-      }
+    try {
+      await createHighlight(highlight, clientRequestId, user.id)
+    } catch (error) {
+      logger.error('Failed to create highlight', {
+        highlight,
+        clientRequestId,
+        userId: user.id,
+      })
     }
   }