Merge pull request #2895 from omnivore-app/fix/web-subscriptions-filter
Fix the filter in the left menu do not create a dependency loop
This commit is contained in:
@ -65,9 +65,9 @@ export function LibraryFilterMenu(props: LibraryFilterMenuProps): JSX.Element {
|
||||
|
||||
useEffect(() => {
|
||||
if (!subscriptionsLoading) {
|
||||
setSubscriptions(networkSubscriptions.filter((s) => s.status == 'ACTIVE'))
|
||||
setSubscriptions(networkSubscriptions)
|
||||
}
|
||||
}, [setSubscriptions, networkLabels, subscriptionsLoading])
|
||||
}, [setSubscriptions, networkSubscriptions, subscriptionsLoading])
|
||||
|
||||
useEffect(() => {
|
||||
if (!searchesLoading) {
|
||||
@ -204,7 +204,9 @@ function Subscriptions(
|
||||
if (!props.subscriptions) {
|
||||
return []
|
||||
}
|
||||
return props.subscriptions.sort((a, b) => a.name.localeCompare(b.name))
|
||||
return props.subscriptions
|
||||
.filter((s) => s.status == 'ACTIVE')
|
||||
.sort((a, b) => a.name.localeCompare(b.name))
|
||||
}, [props.subscriptions])
|
||||
|
||||
useRegisterActions(
|
||||
|
||||
Reference in New Issue
Block a user